-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me: Two-Step: Allow users to 'Switch to a New Device' #19
Comments
This came up in an internal discussion today:
|
This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. |
This issue has been marked as stale and will be closed in seven days. This happened because:
You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation. |
Still an issue: A bit clearer today now with a link to https://en.support.wordpress.com/security/two-step-authentication/#moving-to-a-new-device |
…ways Add space before parent always for async arrows
…ways Add space before parent always for async arrows
…ways Add space before parent always for async arrows
…ways Add space before parent always for async arrows
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
Currently:
When a user gets a new mobile device they must 'disable' and 'enable' 2fa in order to switch phones. That flow is not intuitive to a user. They may not understand that disabling is required. They may (just maybe) continue carrying around their old phone just for auth. They may disable and never re-enable.
Hopefully:
We can implement a 'switch to a different device' option that allows users to 'update' their 2fa settings without disabling 2fa.
Comment:
Hi all,
I've been playing with Google and Dropbox 2FA switching / editing mechanism — Facebook and Twitter have slightly different flow and depend on their mobile apps — and the simplest approach, IMO, is Dropbox. When 2FA is enabled in Dropbox, user can edit the 2FA setting. The 2FA edit screen and flow are basically the same as initial setup of 2FA — user chooses how to retrieve the verification code (sms or app).
UI proposal
Using the same edit pattern as Dropbox allows us to reuse existing
security-2fa-setup
component. Followings show how 2FA edit applied in Calypso:Any thought for the UI?
Code consideration
The
TwoStep
component rendersSecurity2faDisable
when user has 2FA enabled. TheSecurity2faDisable
renders the status of 2FA setting and components related to 2FA disabling processes. Now edit 2FA setting flow is introduced. The nameSecurity2faDisable
doesn't fit to the context anymore as edit and disable buttons are rendered in the same component. I propose the nameSecurity2faEdit
. Basically the disable related functions stay the same, it only introduces new state —editing
. This state is used to indicate whether to prompt disabling section or editing section.When state
editing
istrue
,Security2faEdit
uses 2FA setup component,Security2faSetup
, that renders screenshot no. 2. From there, we need to adjustSecurity2faSetup
component to bypassinitial-setup
state by introducing new propinitialStep
.Todos
Implement
Security2faEdit
. This component replacesSecurity2faDisable
.Allows opt-in
step
state inSecurity2faSetup
by introducing new propinitialStep
. The initial state ofstep
should bethis.props.initialStep || 'initial-setup'
. Another new prop isonCancelSetup
— which allowsSecurity2faEdit
to get back to initial state rather than toSecurity2faSetup
'sinitial-setup
step.Import styles, in
assets/stylesheets/_components.scss
, fromSecurity2faEdit
and remove styles fromSecurity2faDisable
.Update READMEs mentioning
Security2faDisable
component — replaces it withSecurity2faEdit
.Update
TwoStep
component to change the child component toSecurity2faEdit
instead ofSecurity2faDisable
.The REST API endpoints
/me/two-step/app-auth-setup/
always returns error if current user's 2FA is enabled with JSON response:I believe this is intended — from wpcom-undocumented and two-step-authorization it seems no function exposed to deal with updating 2FA settings.
The text was updated successfully, but these errors were encountered: