Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact form block - add example #13629

Merged
merged 8 commits into from
Oct 7, 2019
Merged

Contact form block - add example #13629

merged 8 commits into from
Oct 7, 2019

Conversation

MichaelArestad
Copy link
Contributor

@MichaelArestad MichaelArestad commented Oct 2, 2019 •
edited by joanrho
Loading

Master issue: #13510

Changes proposed in this Pull Request:

Before

image

After

image

Before/After of the field text alignment and bg color fixes:
Screen Shot 2019-10-03 at 4 30 10 PM

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

  • Create a new post
  • Click the + to open the Inserter in the top bar
  • Hover over Form

Proposed changelog entry for your changes:

  • None needed

@MichaelArestad MichaelArestad added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Status] In Progress [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 2, 2019
@MichaelArestad MichaelArestad added this to the 7.9 milestone Oct 2, 2019
@MichaelArestad MichaelArestad requested a review from a team October 2, 2019 21:08
@MichaelArestad MichaelArestad self-assigned this Oct 2, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello MichaelArestad! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33495-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 2, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 1b8b359

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@MichaelArestad
Copy link
Contributor Author

This seems to now work (even though I can't get it to work). I'll take another shot at it in the morning and stub out all the fields to match the mockup.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@jeherve jeherve mentioned this pull request Oct 3, 2019
Closed
15 tasks
@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@MichaelArestad
Copy link
Contributor Author

There appears to be a display bug for blocks with innerblocks. There's a negative left/right margin set that makes the preview look not so great.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@MichaelArestad MichaelArestad added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Oct 3, 2019
@MichaelArestad
Copy link
Contributor Author

Added style overrides to core styles. Creating an issue in Gberg shortly and will link to it, but this will work in the meantime.

@MichaelArestad MichaelArestad mentioned this pull request Oct 3, 2019
Closed
@MichaelArestad
Copy link
Contributor Author

Gutenberg issue:
WordPress/gutenberg#17760

@joanrho
Copy link
Contributor

joanrho commented Oct 3, 2019

Looks great and works as expected!

jeherve
jeherve reviewed Oct 4, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @wordpress/block-editor package used in this PR was only added to WordPress in version 5.2:
https://core.trac.wordpress.org/ticket/46429

Since Jetpack is currently compatible with WordPress 5.1, we can't use this just yet.

However, and as per the discussion in #13620, we should be able to update that requirement to WP 5.2 in the release after the next, once WordPress 5.3 is released for everyone.

Should we wait to merge this until Jetpack 8.0 and our new compatibility change?

Another alternative would be to up our version requirement to WP 5.2 in this release already, but I am afraid this could be problematic for all the folks that still run WordPress 5.1.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 4, 2019
@MichaelArestad
Copy link
Contributor Author

@jeherve Ah! I had no idea. I was just trying to fix some warnings. I'll revert those changes.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33495-code has been updated.

@MichaelArestad
Copy link
Contributor Author

@jeherve fixed

@MichaelArestad MichaelArestad added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 4, 2019
jeherve
jeherve approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merging!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 7, 2019
@jeherve jeherve merged commit 9edf705 into master Oct 7, 2019
@jeherve jeherve deleted the add/contact-form-block-example branch October 7, 2019 10:27
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
[Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.

Jetpack Contact Form block - fix gap between field name and required text
7 participants
@MichaelArestad @matticbot @jetpackbot @joanrho @jeherve @crunnells @gravityrail