Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block preview - negative margin impacting preview visuals #17760

Closed
MichaelArestad opened this issue Oct 3, 2019 · 2 comments
Closed

Block preview - negative margin impacting preview visuals #17760

MichaelArestad opened this issue Oct 3, 2019 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@MichaelArestad
Copy link
Contributor

Describe the bug
During implementation of block previews in Jetpack, I discovered all three blocks that have InnerBlocks display poorly in the preview pane because a core style is adding a negative margin. Here's what that looks like:

image

The Contact Form block is a good example of the problem. In the following PR, I have overwritten these styles to make it look nice in the preview. I did this for the other blocks as well, but that does not address the root problem.

Automattic/jetpack#13629

It looks like the culprit is in this file:
'gutenberg/build/block-editor/style.css?ver=1570107929`

and is this style block:

.block-editor-block-list__block .block-editor-block-list__layout {
 padding-left:0;
 padding-right:0;
 margin-left:-14px;
 margin-right:-14px
}

Found here.

I'm unsure of why that component is used where it is in our blocks or if that's normal. CC @simison

If it's on our end, we'll fix it.

@mapk @retrofox

@MichaelArestad MichaelArestad added the [Type] Bug An existing feature does not function as intended label Oct 3, 2019
@paaljoachim
Copy link
Contributor

I am not sure, but is this issue still valid?

@WordPress/gutenberg-core

@youknowriad
Copy link
Contributor

I thinks is not relevant anymore, the design there changed a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants