Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt in to diffuse color multidraw consolidation #468

Merged
merged 6 commits into from
May 27, 2020
Merged

Opt in to diffuse color multidraw consolidation #468

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1995e92
Turn on multidraw diffuseColor consolidation for MRenderItem's using …
Apr 27, 2020
4835a98
Add API version protection for setWantDiffuseColorMultiDrawConsolidat…
Apr 27, 2020
6757049
Update MayaUSD to use the new version of the prototype API.
May 13, 2020
afe0f88
Remove _isFallbackShader.
May 13, 2020
4231b85
Update for the new interface.
May 14, 2020
5a309f2
Use the already defined MString.
May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/mayaUsd/render/vp2RenderDelegate/render_delegate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ namespace
if (TF_VERIFY(shaderMgr)) {
shader = shaderMgr->getFragmentShader(
_fallbackShaderNames[index], _structOutputName, true);
#if MAYA_API_VERSION >= 20210000
MString diffuseColorParamName("diffuseColor");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use _diffuseColorParameterName which has been defined in the file.

shader->setWantMultiDrawConsolidation(diffuseColorParamName, true);
#endif
}
}

Expand Down