Opt in to diffuse color multidraw consolidation #468
Conversation
…the fallback shader.
williamkrick
added
do-not-merge-yet
|
Can we also enable the flag for material-produced shaders? |
I am not sure. Part of the problem is some materials were getting the flag that didn't support it. We want to prevent that from happening. Can we test those materials in MayaUSD to see if they have a diffuseColor parameter? |
Yes, but I think the API call itself can check the existence of diffuseColor. If not, we could have an explicit lookup with MShaderInstance::parameterList(). |
Yes you are right. Actually the version I'm already working on does a much better job checking that setting the flag is valid and rejecting invalid calls so we should be able to attempt to mark everything as wantMultiDrawConsolidation(). Do you have a suggestion where I can flag those materials off the top of your head? If not I'll dig though and find a place. |
|
My first try would be adding the API call here: This is where the shader instance has just been produced from the full material network. |
|
Based on the offline chat, I don't think we have to add color consolidation for material in the same PR. Appoving the PR. |
| @@ -273,7 +273,8 @@ namespace | |||
| shader = shaderMgr->getFragmentShader( | |||
| _fallbackShaderNames[index], _structOutputName, true); | |||
| #if MAYA_API_VERSION >= 20210000 | |||
| shader->setWantDiffuseColorMultiDrawConsolidation(true); | |||
| MString diffuseColorParamName("diffuseColor"); | |||
There was a problem hiding this comment.
Please use _diffuseColorParameterName which has been defined in the file.
kxl-adsk
removed
do-not-merge-yet
kxl-adsk
deleted the
krickw/MAYA-104223/opt_in_to_diffuseColor_multidraw_consolidation
branch
This change enables multidraw consolidation for render items using the fallback shader in MayaUSD.
The Maya API this change relies on is a prototype API being introduced in PR115. It is appropriate for testing only.