EMSUSD-1118 instance selection highlight #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect the need to redo the selection highlight by detecting if the instance count changed. Unfortunately, the instancer index version only changes when an instance was toggle off, not when togged on. Might be a bug or not in USD, but we work around it by tracking the instance count too.
pierrebai-adsk
added
bug
Does it depend on an attribute change? |
AramAzhari-adsk
previously approved these changes
Apr 30, 2024
The fix is only available in somewhat recent USD versions. Maya 2022 and 2024 are not supported.
pierrebai-adsk
changed the title
AramAzhari-adsk
previously approved these changes
Apr 30, 2024
Explicitly set the selection instead of trying to change the images because the behavior is different between Maya 2022 and the later versions because the fix is only available starting with Maya 2023. It is simpler to make the text behave the same in all version by explicitly selecting the object that the image expect to be selected. (Even if it was by mistake in Maya 2022...)
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1118/instanceable-highlight
branch
from
26b0890 to
7dd8c08
Compare
AramAzhari-adsk
approved these changes
Apr 30, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
vp2renderdelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the need to redo the selection highlight by detecting if the instance count changed. Unfortunately, the instancer index version only changes when an instance was toggle off, not when togged on. Might be a bug or not in USD, but we work around it by tracking the instance count too.