vp2RenderDelegate can highlight wrong point instances selection after instancer changes.

[jufrantz]

Describe the bug

Viewport selection highlighting can get wrong after changing some instancer attributes like invisibleIds and protoIndices.

Steps to reproduce

1. Create a mayaUsd proxyShape with an usd point instancer.

import pxr.UsdGeom
import maya.cmds
import mayaUsd.ufe
import mayaUsd_createStageWithNewLayer

maya.cmds.loadPlugin("mayaUsdPlugin", quiet=True)

proxyShape = mayaUsd_createStageWithNewLayer.createStageWithNewLayer()
shapeStage = mayaUsd.ufe.getStage(proxyShape)

shapeStage.GetRootLayer().ImportFromString('''#sdf 1
(
    defaultPrim="PI"
)
def PointInstancer "PI"
{
    point3f[] positions = [(0, 0, 0), (2, 0, 2), (2, 0, -2), (-2, 0, -2), (-2, 0, 2)]
    int[] protoIndices = [0, 0, 1, 1, 1]
    rel prototypes = [</PI/Protos/Sphere>, </PI/Protos/Cube>]

    def Scope "Protos"
    {
        def Sphere "Sphere" {}
        def Cube "Cube" {}
    }
}
''')

2. Select point instances at usd indices 2 and 3.

instancer = pxr.UsdGeom.PointInstancer(shapeStage.GetDefaultPrim())
instanceIndices = [2, 3]
maya.cmds.select([f"{proxyShape},{instancer.GetPath()}/{idx}" for idx in instanceIndices])
# Ensure viewport selection hiliting is updated
maya.cmds.refresh()

3. Make instances invisible by setting invisibleIds attribute

instancer.GetInvisibleIdsAttr().Set(instanceIndices)

4. Notice that instance 4 is now wrongly highlighted.

5. Rebuild the scene by redoing steps 1) and 2).

6. Change per-instance prototypes by setting protoIndices attribute

instancer.GetProtoIndicesAttr().Set([1, 1, 0, 0, 0])

7. Notice that instances 0 and 1 are now wrongly highlighted.

Expected behavior

We expect viewport to highlight the point instances of ufe global selection even after instancing editions.

Specs (if applicable):

• CentOS 7.8
• Maya 2023.3
• maya-usd 0.25
• USD 22.11

[jufrantz]

I retested with v0.30.0, and this appears to be resolved, very likely due to #3744 .
Thank you! Closing the issue now.