MAYA-107303 - UFE: crash (debug only) with multiple UFE items in single string #1039
Conversation
… items in single string * When asking for UsdPrim from Ufe Path we cannot assume the path is valid and therefore should not assert.
| if(BUILD_PXR_PLUGIN) | ||
| # This test uses the file "UsdExportUVTransforms.ma" which | ||
| # requires the plugin "pxrUsdPreviewSurface" that is built by the | ||
| # Pixar plugin. | ||
| list(APPEND TEST_SCRIPT_FILES | ||
| testUsdExportUVTransforms.py | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
I had built locally only the maya-usd plugin and got this test failing. Found it is because of the ma file it loads (there is another example of this).
There was a problem hiding this comment.
A better approach would be to port this test to use usdPreviewSurface node that is independent of Pixar plugin - see https://github.com/Autodesk/maya-usd/blob/dev/lib/usd/pxrUsdPreviewSurface/usdPreviewSurfacePlugin.cpp
There was a problem hiding this comment.
Let's do that in a separate PR. I copied this way of skipping the test from another place. So there are multiple tests that need to be ported.
lib/mayaUsd/ufe/Utils.cpp
Outdated
| @@ -50,6 +50,10 @@ template <> struct iterator_traits<MStringArray::Iterator> | |||
| } // namespace std | |||
| #endif | |||
|
|
|||
| namespace { | |||
| static constexpr auto kIllegalUSDPath = "Illegal USD run-time path %s."; | |||
There was a problem hiding this comment.
Nit-pick: since this is in the unnamed namespace, static is redundant.
… items in single string * minor - code review and style fix.
seando-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
donnels/MAYA-107303/crash_with_multiple_ufe_items_in_single_string
branch
MAYA-107303 - UFE: crash (debug only) in MEL parser with multiple UFE items in single string