Cleanup: Use SoundSpecifier instead of string literals in ``Vomit…

…System`` (space-wizards#35426) * Cleanup * Update * Update
ArtisticRoomba · Feb 23, 2025 · fa73217 · fa73217
1 parent 91f2c46
commit fa73217
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/Content.Server/Medical/VomitSystem.cs b/Content.Server/Medical/VomitSystem.cs
@@ -31,6 +31,12 @@ public sealed class VomitSystem : EntitySystem
         [Dependency] private readonly ForensicsSystem _forensics = default!;
         [Dependency] private readonly BloodstreamSystem _bloodstream = default!;
 
+        [ValidatePrototypeId<SoundCollectionPrototype>]
+        private const string VomitCollection = "Vomit";
+
+        private readonly SoundSpecifier _vomitSound = new SoundCollectionSpecifier(VomitCollection,
+            AudioParams.Default.WithVariation(0.2f).WithVolume(-4f));
+
         /// <summary>
         /// Make an entity vomit, if they have a stomach.
         /// </summary>
@@ -94,7 +100,7 @@ public void Vomit(EntityUid uid, float thirstAdded = -40f, float hungerAdded = -
             }
 
             // Force sound to play as spill doesn't work if solution is empty.
-            _audio.PlayPvs("/Audio/Effects/Fluids/splat.ogg", uid, AudioParams.Default.WithVariation(0.2f).WithVolume(-4f));
+            _audio.PlayPvs(_vomitSound, uid);
             _popup.PopupEntity(Loc.GetString("disease-vomit", ("person", Identity.Entity(uid, EntityManager))), uid);
         }
     }

diff --git a/Resources/Prototypes/SoundCollections/disease.yml b/Resources/Prototypes/SoundCollections/disease.yml
@@ -62,3 +62,8 @@
   id: Honks
   files:
   - /Audio/Items/bikehorn.ogg
+
+- type: soundCollection
+  id: Vomit
+  files:
+  - /Audio/Effects/Fluids/splat.ogg