Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Use SoundSpecifier instead of string literals in VomitSystem #35426

Merged
merged 3 commits into from
Feb 23, 2025
Merged

Cleanup: Use SoundSpecifier instead of string literals in VomitSystem #35426

merged 3 commits into from
Feb 23, 2025

Conversation

Winkarst-cpu
Copy link
Contributor

About the PR

Title.

Why / Balance

Obsolete. #33279.

Technical details

Media

Requirements

Breaking changes

Changelog
Nope.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2025
PJB3005
PJB3005 requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be made sound collections.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2025
@Winkarst-cpu Winkarst-cpu requested a review from PJB3005 February 23, 2025 21:01
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Feb 23, 2025
PJB3005
PJB3005 requested changes Feb 23, 2025
View reviewed changes
@Winkarst-cpu Winkarst-cpu requested a review from PJB3005 February 23, 2025 21:41
@PJB3005 PJB3005 merged commit fa73217 into space-wizards:master Feb 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

Assignees
No one assigned
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winkarst-cpu @PJB3005