Add optional title attribute to the code examples #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything we can do to make this pull request more attractive? The feature to have titles for examples and to be able to remember which example to show in doc even after example regeneration seem useful? |
|
Hi, seems reasonable, there is another PR #130 that also touches the examples.yml (converting it into json), I would like to get them both at the same time, resolving conflicts while in it. ETA 1 week for me to get the new release out. |
|
Is it possible to merge this? Or do you want me to make changes? |
|
Thanks, merging now |
iNecas
added a commit
that referenced
this pull request
Dec 8, 2014
Add optional title attribute to the code examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there are any changes you need before you can merge this.