[Fixes #125] Dump examples as json #130
Conversation
|
Any update on this? The PR fixed all unparsable example files for us. |
|
Hi, sry for the delay, I need to update our projects to work with this change and changed the version to 0.x.0 because it's more than just a bug-fix, therefore this delay. Would a release sometime the following two weeks work for you? |
|
Sure I was just asking, whether I should change something :) Thanks for the update 👍 |
|
@iNecas any update on this? |
|
Man, I feel so bad about this one. And in general, I'm horrible person on maintaining this gem. Please be patient with me. I have a major release of apipie with this change included on my new-years resolution. Also waiting for couple of additions for API/CLI bindings based on the docs. |
|
@iNecas as 0.1.0 is now released 😎, should I rebase or close the PR? |
|
As MultiJson is used, you should add |
|
Rails and other gems removed the |
|
Yes, so we should perhaps use the json gem instead of multi_json. |
|
Updated and passing :-) |
|
Thanks, I would like to get this and #187 in and do 0.2.0 later this week. Does that work for you? |
|
Sure, #187 looks awesome :-) |
| @@ -17,6 +17,7 @@ Gem::Specification.new do |s| | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.add_dependency "rails", ">= 3.0.10" | |||
| s.add_dependency "json", ">= 1.7" | |||
There was a problem hiding this comment.
Any particular reason for making this version requirement?
There was a problem hiding this comment.
It worked for me with JSON 1.5.5 as well, I would remove that if you don't mind
There was a problem hiding this comment.
Rails 4.1 is requiring 1.7.7 due to a fixed security issue. rails/rails@78cd3b0
There was a problem hiding this comment.
The problem is, it's not unusual that software vendors (e.g. Red Hat provides security patches to older version of software, so it looks like the version is 1.5.5, but the security issues are being backported. Therefore, ideally, the version constraints should be there only in cases it requires the functionality that was not before.
|
ok, rebased and version requirement removed. |
|
Nice, the only thing pending is the travis failing on ruby 2.1, which is not related to this PR, once travis fixes that, I will merge that finally! Thanks for patience with me :) |
|
Sure, just send you #235 , this fixes travis. |
[Fixes #125] Dump examples as json
|
That should be the solution! Thanks for both |
|
Yeah 🎉 😄 |
|
And as promised, 0.2.0 is out. Almost on time :D Thanks for the patience again |
As I had several encoding issues while loading the recorded examples from the yaml file and converting them to json in the documentation, I changed the default storage format to json.
I added also some tests for the writer to ensure the result is now that same as before. You can use the
apipie:convert_examplestask to convert the existing examples.