-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fixes #3966
Merged
Merged
Backport fixes #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add null checks on role mapping * Add check for Role and Unit Test
* Fix default value converter * Add test for default byte type value in converter test
Thank you for creating a pull request! Pinging @EricWittmann to respond or triage. |
13ebb0c
to
29d2fd7
Compare
carlesarnal
added a commit
to carlesarnal/apicurio-registry
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (Apicurio#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (Apicurio#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (Apicurio#3637) * Incorrect default value avro serialization (Apicurio#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (Apicurio#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <[email protected]> Co-authored-by: Eric Wittmann <[email protected]> Co-authored-by: Jean Xiao <[email protected]> Co-authored-by: Anshu Anna Moncy <[email protected]> Co-authored-by: j2gg0s <[email protected]>
carlesarnal
added a commit
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (#3637) * Incorrect default value avro serialization (#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <[email protected]> Co-authored-by: Eric Wittmann <[email protected]> Co-authored-by: Jean Xiao <[email protected]> Co-authored-by: Anshu Anna Moncy <[email protected]> Co-authored-by: j2gg0s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.