Fix Owner Validation #3593
Merged
Fix Owner Validation #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
reviewed
Aug 23, 2023
| @@ -259,7 +259,13 @@ public void updateArtifactOwner(String groupId, String artifactId, ArtifactOwner | |||
| requireParameter("groupId", groupId); | |||
| requireParameter("artifactId", artifactId); | |||
|
|
|||
| ArtifactOwnerDto dto = new ArtifactOwnerDto(data.getOwner()); | |||
| String owner = data.getOwner(); | |||
| requireParameter("owner", owner); | |||
There was a problem hiding this comment.
Is calling the requireParameter method not sufficient for this purpose?
carlesarnal
requested changes
Aug 23, 2023
|
Hi @carlesarnal , thank you for the review. I thought |
renjingxiao
force-pushed
the
non-empty-owner
branch
from
bd602fd to
836e1d3
Compare
|
Hi @carlesarnal , |
EricWittmann
approved these changes
Aug 29, 2023
carlesarnal
pushed a commit
to carlesarnal/apicurio-registry
that referenced
this pull request
Nov 13, 2023
carlesarnal
added a commit
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (#3637) * Incorrect default value avro serialization (#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <[email protected]> Co-authored-by: Eric Wittmann <[email protected]> Co-authored-by: Jean Xiao <[email protected]> Co-authored-by: Anshu Anna Moncy <[email protected]> Co-authored-by: j2gg0s <[email protected]>
carlesarnal
added a commit
to carlesarnal/apicurio-registry
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (Apicurio#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (Apicurio#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (Apicurio#3637) * Incorrect default value avro serialization (Apicurio#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (Apicurio#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <[email protected]> Co-authored-by: Eric Wittmann <[email protected]> Co-authored-by: Jean Xiao <[email protected]> Co-authored-by: Anshu Anna Moncy <[email protected]> Co-authored-by: j2gg0s <[email protected]>
Merged
carlesarnal
added a commit
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (#3637) * Incorrect default value avro serialization (#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <[email protected]> Co-authored-by: Eric Wittmann <[email protected]> Co-authored-by: Jean Xiao <[email protected]> Co-authored-by: Anshu Anna Moncy <[email protected]> Co-authored-by: j2gg0s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @EricWittmann and @carlesarnal ,
In this PR I have added checks for the
ownerto ensure it's neithernullor an empty string.MissingRequiredParameterExceptionwill be thrown if the check fails.It will close #3476 .
Thank you for reviewing.