Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: context based login with ansattporten #14014

Merged
merged 114 commits into from
Nov 21, 2024
Merged

feat: context based login with ansattporten #14014

merged 114 commits into from
Nov 21, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Nov 8, 2024 •
edited
Loading

Added Maskinporten tab to settings modal

Description

Added a new Maskinporten tab to the settings modal that allows users to authenticate with Ansattporten. The tab includes:

  • Login status check functionality
  • Login button and descriptive text for unauthenticated users
  • Placeholder view for authenticated users
  • Full test coverage for the new components
  • Norwegian translations for all new text strings
  • New query hook for checking Ansattporten login status (but it's response is mocked, waiting for backend)

Related Issue(s)

Verification

  • Code builds clean without any errors or warnings
  • Manual testing done
  • Relevant automated test added

framitdavid and others added 26 commits October 25, 2024 13:11
@framitdavid
Resuable storage interface
da60ad5
@framitdavid
moved the reusable scoped storage to pure-funciton
03ad004
@framitdavid
spelling
13a3d2a
@framitdavid
added missing method
e2c8b73
@framitdavid
syntax
50fd70d
@framitdavid
added more precise return type
8ca15da
@framitdavid
typecheck
d64d4cf
@framitdavid
eslint
1893117
@framitdavid
added assertion
d1994ee
@framitdavid
moved test section to be more readable
7c50e30
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
6b30edb
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
b29b699
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
69cb859
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
1b48c15
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
91d17ec
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
4e38a26
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
64de22b
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
327b25b
@framitdavid
Merge branch 'main' of https://github.com/Altinn/altinn-studio
5926dfe
@framitdavid
feat(settings): make it possible to open settings modal based on quer…
210f60b 
…y-params
@framitdavid
fixes
7a5266c
@framitdavid
improved test description
1424bb6
@framitdavid
Merge branch 'main' into feat/openSettingsModalBasedOnQueryParam
212d80d
@framitdavid
PR-feedback + improve unit-tests
b9a0731
@framitdavid
Merge branch 'feat/openSettingsModalBasedOnQueryParam' of https://git…
d3026e9 
…hub.com/Altinn/altinn-studio into feat/openSettingsModalBasedOnQueryParam
@framitdavid
feat: context based login with ansattporten
7dd7f68
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 8, 2024
@framitdavid
Copy link
Collaborator Author

framitdavid commented Nov 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@framitdavid framitdavid mentioned this pull request Nov 8, 2024
Merged
3 tasks
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/version-control Area: Related to version control for files in apps. quality/testing Tests that are missing, needs to be created or could be improved. backend kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 20, 2024
@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 21, 2024
@wrt95 wrt95 enabled auto-merge (squash) November 21, 2024 08:32
@framitdavid framitdavid disabled auto-merge November 21, 2024 09:46
@framitdavid framitdavid merged commit 498673f into main Nov 21, 2024
10 of 12 checks passed
@framitdavid framitdavid deleted the 11-08-feat_context_based_login_with_ansattporten branch November 21, 2024 09:47
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@framitdavid @wrt95
@mirkoSekulic @nkylstad
feat: context based login with ansattporten (#14014)
6554edf 
Co-authored-by: William Thorenfeldt <[email protected]>
Co-authored-by: Mirko Sekulic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@wrt95 wrt95 wrt95 approved these changes

Assignees

@framitdavid framitdavid

Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/version-control Area: Related to version control for files in apps. backend frontend kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@framitdavid @wrt95 @mirkoSekulic