-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): make it possible to open settings modal based on query-params #13996
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13996 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 1774 1775 +1
Lines 23099 23115 +16
Branches 2684 2685 +1
=======================================
+ Hits 22016 22033 +17
+ Misses 835 834 -1
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
frontend/app-development/hooks/useOpenSettingsModalBasedQueryParam.ts
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/useOpenSettingsModalBasedQueryParam.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🥳
ad88000
to
d3026e9
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d3026e9
to
1521f6e
Compare
…y-params (#13996) Co-authored-by: William Thorenfeldt <[email protected]>
Description
This feature enables users to open the settings modal based on query parameters. The functionality is particularly useful after logging in via the ansattporten, allowing users to seamlessly continue where they left off by directly accessing the settings modal, after redirect back to Studio.
Related Issue(s)
Verification