Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): make it possible to open settings modal based on query-params #13996

Merged
merged 27 commits into from
Nov 19, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Nov 6, 2024

Description

This feature enables users to open the settings modal based on query parameters. The functionality is particularly useful after logging in via the ansattporten, allowing users to seamlessly continue where they left off by directly accessing the settings modal, after redirect back to Studio.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 6, 2024
@framitdavid framitdavid marked this pull request as ready for review November 6, 2024 14:26
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (69d00c9) to head (fee1916).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13996   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files        1774     1775    +1     
  Lines       23099    23115   +16     
  Branches     2684     2685    +1     
=======================================
+ Hits        22016    22033   +17     
+ Misses        835      834    -1     
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments 😄

@framitdavid framitdavid requested a review from wrt95 November 6, 2024 19:50
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🥳

@framitdavid framitdavid force-pushed the feat/openSettingsModalBasedOnQueryParam branch from ad88000 to d3026e9 Compare November 8, 2024 11:08
@framitdavid
Copy link
Collaborator Author

framitdavid commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@framitdavid framitdavid force-pushed the feat/openSettingsModalBasedOnQueryParam branch from d3026e9 to 1521f6e Compare November 14, 2024 22:20
@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 19, 2024
@wrt95 wrt95 merged commit 439262e into main Nov 19, 2024
11 checks passed
@wrt95 wrt95 deleted the feat/openSettingsModalBasedOnQueryParam branch November 19, 2024 13:22
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants