Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-modeling): only valid models are bindable #13985

Merged
merged 9 commits into from
Nov 14, 2024
Merged

feat(data-modeling): only valid models are bindable #13985

merged 9 commits into from
Nov 14, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Nov 5, 2024

Description

Datatypes shown in binding select is now limited to

  • default datamodel
    OR
  • applogic present
  • maxCount == 1
multiple-datamodels-only-valid-shown.mp4

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr linked an issue Nov 5, 2024 that may be closed by this pull request
Ensure only relevant/valid data types are made available #13795
Closed
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 5, 2024
@Jondyr Jondyr changed the title feat(multipledatamodels): only valid models are bindable feat(data-modeling): only valid models are bindable Nov 5, 2024
@Jondyr Jondyr force-pushed the 13795-ensure-only-relevantvalid-data-types-are-made-available branch from 7387bf2 to 3499607 Compare November 5, 2024 13:13
@Jondyr Jondyr force-pushed the 13795-ensure-only-relevantvalid-data-types-are-made-available branch from 3499607 to 9ca9914 Compare November 5, 2024 13:39
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (4d8c7e3) to head (d861d96).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13985   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files        1763     1764    +1     
  Lines       23000    23017   +17     
  Branches     2676     2678    +2     
=======================================
+ Hits        21915    21932   +17     
  Misses        836      836           
  Partials      249      249

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr added the skip-releasenotes Issues that do not make sense to list in our release notes label Nov 6, 2024
@Jondyr Jondyr marked this pull request as ready for review November 6, 2024 10:37
JamalAlabdullah
JamalAlabdullah reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 works fine, just a small thing

@Jondyr Jondyr force-pushed the 13795-ensure-only-relevantvalid-data-types-are-made-available branch from 02fc39c to e45a621 Compare November 7, 2024 14:43
@lassopicasso lassopicasso mentioned this pull request Nov 8, 2024
Merged
4 tasks
JamalAlabdullah
JamalAlabdullah approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

lassopicasso
lassopicasso approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in dev - brilliant work! :)

@lassopicasso lassopicasso merged commit 022f49c into main Nov 14, 2024
8 checks passed
@lassopicasso lassopicasso deleted the 13795-ensure-only-relevantvalid-data-types-are-made-available branch November 14, 2024 14:16
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@Jondyr @lassopicasso @nkylstad
feat(data-modeling): only valid models are bindable (#13985)
6976430 
Co-authored-by: Lars <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassopicasso lassopicasso lassopicasso approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure only relevant/valid data types are made available
3 participants
@Jondyr @lassopicasso @JamalAlabdullah