feat: 13928 add data model binding for subfrom

[JamalAlabdullah]

Description

• Added anew componenet called SubformDataModelSelect that render StudioNativeSelect to the recommendedAction card to choose the datamodel that will be binded to the created subform.
• Added tests

Related Issue(s)

• feat/add data model binding for subfrom #13928

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable).

Screen.Recording.2024-11-08.at.12.51.44.mov

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (95a0859) to head (009f125).
Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13961      +/-   ##
==========================================
- Coverage   95.21%   95.21%   -0.01%     
==========================================
  Files        1713     1714       +1     
  Lines       22586    22603      +17     
  Branches     2641     2643       +2     
==========================================
+ Hits        21506    21521      +15     
- Misses        834      836       +2     
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mlqn]

Nice work! 🚀

[lassopicasso]

Looks good! However, the create button for a new subform needs to be disabled until both the name and data model are selected. A subform need to be linked to a data model 🙂

Also, when selecting a data model for the subform, the preview shows an error saying the selected data model is not valid. Is there a separate issue for that, or should the data model selector in this PR handle this with only display valid data models for subform?
@lassopicasso I am not sure about this error in preview , i could not find it when i select between datatype modell

[lassopicasso]

@lassopicasso I am not sure about this error in preview , i could not find it when i select between datatype modell

The error in the preview from the main layout set appears when you create a new subform linked to a data model.

Otherwise, the code looks good, and I have verified that the button is disabled. If you decide not to address this issue in this PR, could you please raise it with the rest of our domain group? 🙂 This might be something that will be handled in a separate issue, but I couldn't find an existing one, so perhaps a new issue should be created if that's the case.

I approve this for now, so feel free to merge it if you don't plan to address this in this issue. 🙂

Edit: @Jondyr will perhaps this PR: #13985 fix this issue?

[lassopicasso]

See comment above 🙂

[Jondyr]

@lassopicasso I am not sure about this error in preview , i could not find it when i select between datatype modell

The error in the preview from the main layout set appears when you create a new subform linked to a data model.

Otherwise, the code looks good, and I have verified that the button is disabled. If you decide not to address this issue in this PR, could you please raise it with the rest of our domain group? 🙂 This might be something that will be handled in a separate issue, but I couldn't find an existing one, so perhaps a new issue should be created if that's the case.

I approve this for now, so feel free to merge it if you don't plan to address this in this issue. 🙂

Edit: @Jondyr will perhaps this PR: #13985 fix this issue?

No, #13985 will not affect this. This is likely because of the applogic parameter "alllowedInSubform" not being set to true. Which apps should remove soon, as stated by @nkylstad . So from my understanding, we just have to wait for this one to be updated on app-frontend

[lassopicasso]

No, #13985 will not affect this. This is likely because of the applogic parameter "alllowedInSubform" not being set to true. Which apps should remove soon, as stated by @nkylstad . So from my understanding, we just have to wait for this one to be updated on app-frontend

Thanks for the explanation, and I’m sorry to disturb you on your day off 😄

I merge this then, @JamalAlabdullah 🙂