Enabled napi build for building library

[flickyiyo]

No description provided.

[Adjective-Object]

I think this change implies a significant change specially when it comes

to evaluate the fences path, can we create a ticket to address this after integrating it with owa-builld/client-web? I'm not sure I follow - what's the issue here? Why is this a significant change? It doesn't seem like a good idea to pollute the host process's state under any circumstance. If you don't want to set that up now, you could error when called with a root dir that isn't the cwd and clean it up later.

…

On Thu, Sep 29, 2022, 17:57 Edgar Vazquez ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/lib.rs <#11 (comment)> : > + output: output.unwrap_or("good-fences-violations.json".to_owned()), + }; + run_evaluations(args); +} + +pub fn run_evaluations(args: cli::Cli) { + let start = Instant::now(); + let root = Path::new(args.root.as_str()); + let tsconfig_path = args.project; + let mut tsconfig = import_resolver::TsconfigPathsJson::from_path(tsconfig_path).unwrap(); + + if args.base_url.is_some() { + tsconfig.compiler_options.base_url = args.base_url; + } + + assert!(std::env::set_current_dir(&root).is_ok()); I think this change implies a significant change specially when it comes to evaluate the fences path, can we create a ticket to address this after integrating it with owa-builld/client-web? — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI62SX2O6JFIFOTBQ6AJBDWAYGD3ANCNFSM6AAAAAAQYAZILQ> . You are receiving this because your review was requested.Message ID: ***@***.*** com>

[Adjective-Object]

looks good to me, just a few small tweaks left