Made cli via node #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,16 @@ | |||
| #! /usr/bin/env node | |||
| const { goodFences } = require('./index'); | |||
There was a problem hiding this comment.
what is .index here? Is this a generated js bridge from napi? Is some index.node file with the actual node bindings?
Please update with a comment because I am a confused old man👴
There was a problem hiding this comment.
napi build generates a .node and index.js, index.d.ts files.
The index files are the ones that actually call the .node file but they contain js/ts friendly definitions of all the things annotated with #[napi] in the Rust code.
There was a problem hiding this comment.
btw, how old are you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem with linux, seems that compiling cross dynamic libraries while using that code in a binary for linux is not that straightforward.
Fixing the issue would not be hard but since we are including the napi-rs to make it node compatible is it maybe worth using node/npm to publish the cli?