420chan, small updates, and crash/bugfixes!

Next update: March 21, 2020 @ 11:59 PM PDT. Sorry for the delay!

GENERAL IMPROVEMENTS

• PR #518, #413, adds 420chan as a site. Thanks to @Lolzen for the implementation!
• PR #679, allows the image viewer to handle MP3, M4A, OGG, FLAC, and SWF files and also allows link parsing of links to such assets. Note that SWF files are not internally viewable. Thanks to @Lolzen!
• Notification changes: LastPageNotifications were not alerting in the background and are now a JobService that should properly display these; Notification channels are now made on app startup; some cleanup associated with objects being instantiated strangely.
• PR #712, #694, #687, #638, #579, #703; possibly #696, #690, #560; there's a lot to this one. Here's a rundown:
  • FSAF updates, should fix a lot of issues on that front!
  • File cache updates, should be fewer crashes!
  • File names and directories have had their naming restrictions relaxed. Spaces are still not allowed.
  • Inlined files won't be downloaded in local threads or album downloads anymore.
  • Updates now display a dialog if you want to retain a copy of the APK somewhere. This can be disabled in Behaviour -> Other.
• PR #745, crash logs older than 3 days will be deleted, and crash logs will be timestamped; uncaught stack traces won't be appended twice.

UI CHANGES

• #334, #707, updates to the UI so that you can have the search menu open at the same time as the reply menu and no UI elements should overlap/be hidden (you may still need to scroll around, but everything should be visible scrolling); reply menu must be opened first to have both open at the same time. Works in both bottom and regular input modes.
• #709, fixes a frame-long visual glitch in that the preview image for when a gallery viewer is being exited would be the first image opened, instead of the most recently viewed image.
• Addendum to #679, audio files without album art will display a default volume up drawable, so you know something is there.

CRASH FIXES

• #701, prevents an NPE from occurring.
• #699, allows controller push transitions from null to something by disabling the animation parameter if the method was called as animated.
• #692, fixes a concurrent access issue with the filter controller.
• PR #705, #674, fixes snackbars appearing too high on Android Q.
• #717, fixes a crash caused by a content length of 0 attempting to be used for a percent uploaded UI update.
• #722, fixes a crash and prevents crashes that are caused by the thread presenter not being bound when certain actions occur.
• PR #731, #730, fixes a crash caused by alternate file pickers not having the READ_URI permission.
• PR #729, #708, fixes a concurrent modification exception when streaming WEBMs.
• PR #728, #720, more gracefully deal with local thread deserialization exceptions, to prevent crashes.
• #736, prevents null or empty Strings from being passed into the AndroidUtils open link functions.
• #739, prevents a crash caused by no useable result being returned in the image picker. Also PR #753, #752.
• #740, prevents a crash caused by no file picker intents being available to select a file.
• #733, fixes a crash due to a fix in #722 which appeared as a result of a saved reply not having a field initialized by the database.
• #743, please stop being having the fastest fingers in the west.
• #735, ensures that the saving notification is only started when it is in the foreground of the application; if a notification update happens when the app is in the background, the notification will be cancelled.
• #742, #750, prevents crashes with WEBM streaming calling listeners after the data source was destroyed.
• #747, if the default data of an image picker is null, it will try to get a URI from the clip data in the returned intent. Should help with MEGA at the very least.
• #748, more preventions for weird race conditions with touches.
• #758, if captcha cookies fail to parse when opening up the editor, you will be prompted to re-enter them.
• PR #754, #716, attempts to fix an NPE when calling a function on a background thread.
• PR #757, #661, fixes a number of synchronization issues causing NPEs and crashes. Adds a setting for DEV to disable safe background thread checking.

GENERAL FIXES

• #702, fixes thread loading.
• #704, fixes audio captcha not correctly displaying the keyboard.
• Fixes a semi-softlock where WEBMs in immersive mode would never show the system UI, making it impossible to back out of the image viewer.
• #744, prevents a softlock from occurring when the image viewer is backed out of before the animation to present the first image isn't finished playing. Back actions are disabled until this occurs.
• Fixes a regression that would not dismiss the new posts snackbar when viewing the bottom most post in a thread.
• Fixes an issue where tapping on "pause pins" would not update the notification if you had threads being downloaded.
• PR #726, fixes a thread downloading bug where a pin's downloading state was not set to not download anymore if you swiped away the pin.
• #725, reverts changes for #676. Unfortunately, the scrolling-to-the-top bug continues to rear its ugly head, albeit less. If this happens, sorry, but I don't have a way of properly understanding what to do about the issue. Not using shift-post formatting will likely prevent the issue entirely.
• #279, mitigations per recent findings with isInForeground to more correctly scroll to the correct post when loading from a URL.
• WEBM files should not longer "pop" when they're muted by default.
• #751, fixes a memory leak caused by the floating board selection menu.

DEVELOPMENT WORK

• A few changes have been pushed to the Super-Patch, to better facilitate quickly fixing issues over there.