Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box covers up search result when reply box is active #707

Closed
Astridchan opened this issue Feb 23, 2020 · 2 comments
Closed

Search box covers up search result when reply box is active #707

Astridchan opened this issue Feb 23, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Astridchan
Copy link

Astridchan commented Feb 23, 2020

Issue related to #334 : Often when I'm writing a reply I'll want to quote a certain post or copy text from it. If it's a thread with a lot of posts I'll use the search to find the post rather than try to find it by scrolling through the thread. The issue is that if you have the reply box and search box open simultaneously the search box will cover the first search result and prevent quoting the post since the post text and menu button are covered:

Screenshot_20200223-150158 (1)

Another issue is with the back button behaviour. You would think an easy solution to the above issue would be to just close the reply box and then quote the post, but if you have the keyboard, search box and reply box all open then the back button closes them in the following order:

  1. back button press closes keyboard
  2. closes search
  3. closes reply box

so trying to close the reply box ends up clearing the search instead. The following order would make sense since the reply box can be toggled without losing the content:

  1. back button press closes keyboard
  2. closes reply box
  3. closes search
@Adamantcheese Adamantcheese added bug Something isn't working cantrepro Can't reproduce this issue labels Feb 24, 2020
@Adamantcheese Adamantcheese self-assigned this Feb 24, 2020
@Adamantcheese
Copy link
Owner

I can't replicate the "found x posts" box appearing over any posts. Because of how the UI is structured, I can't change the back press behavior; the toolbar always gets priority.

@Astridchan
Copy link
Author

I can't replicate the "found x posts" box appearing over any posts.

It happens on my Android 9.0 phone and Android 7.0 tablet. I can also reproduce it using a virtual device in Android Studio. Just to be clear, you need to have the reply box and and search box both visible for this issue to happen.

Uuntitled

@Adamantcheese Adamantcheese removed the cantrepro Can't reproduce this issue label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants