Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/512/sync order files on order callback trigger #476

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented Sep 27, 2023

Pull Request

Description:

The file updates were not getting delivered via callbacks. As asked we included file sync login within order callback action similar to what is done in contentful connector.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • File sync logic with in order callback action.
  • Order activity log on order/file callback receiving.

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

  • Can be tested by a round trip where files are completed on acclaro and same should sync automatically to craft in some cool down time.

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
image

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster marked this pull request as ready for review September 27, 2023 11:19
@bhupeshappfoster bhupeshappfoster merged commit 37f09b7 into release/3.3.1 Sep 28, 2023
@bhupeshappfoster bhupeshappfoster mentioned this pull request Oct 5, 2023
12 tasks
@bhupeshappfoster bhupeshappfoster deleted the feature/512/sync-order-files-on-order-callback-trigger branch October 5, 2023 11:32
bhupeshappfoster added a commit that referenced this pull request Oct 5, 2023
* fixed: an issue where uploaded assets saving to temp directory only

* Feature/512/sync order files on order callback trigger (#476)

* added: file sync logic within order callback action

* added: activity logs for callbacks

* fixed: issue saving file when callback received

* Bug/475/error when plugin tag group is deleted by user (#479)

* added: logic to add plugins tag group if deleted by user

* added: google translator library for google translations (#470)

* updated: change log and version bumped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants