Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: google translator library for google translations #470

Merged
merged 3 commits into from
Oct 5, 2023
Merged

added: google translator library for google translations #470

merged 3 commits into from
Oct 5, 2023

Conversation

bhupeshappfoster
Copy link
Collaborator

@bhupeshappfoster bhupeshappfoster commented Sep 13, 2023 •
edited
Loading

Pull Request

Description:

Added google translate logic using google/cloud-translate library deprecating old guzzle client logic.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • Google loud translation client for google translations.

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster changed the title added google translator library for google translations added: google translator library for google translations Sep 13, 2023
@bhupeshappfoster bhupeshappfoster changed the base branch from release/3.2.11 to release/3.3.0 September 18, 2023 07:13
@bhupeshappfoster
Merge branches 'bug/466/google-translator-411-length-required-in-head…
a8de7a7 
…ers' and 'release/3.3.1' of github.com:AcclaroInc/craft-translations into bug/466/google-translator-411-length-required-in-headers
@bhupeshappfoster bhupeshappfoster changed the base branch from release/3.3.0 to release/3.3.1 September 26, 2023 14:45
sidedwards
sidedwards approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@sidedwards sidedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :shipit:

@sidedwards sidedwards linked an issue Sep 29, 2023 that may be closed by this pull request
Google translation - 411 Length Required error #466
Closed
@bhupeshappfoster
Copy link
Collaborator Author

@sidedwards @shnsumit

There was an issue found while testing which was wrong source and target locales sent to google translator. The issue now has been fixed.

This has now been tested with large entry data translation without any errors. Please review again to proceed for release 3.3.1

@bhupeshappfoster bhupeshappfoster merged commit 1c5fac2 into release/3.3.1 Oct 5, 2023
@bhupeshappfoster bhupeshappfoster deleted the bug/466/google-translator-411-length-required-in-headers branch October 5, 2023 11:32
bhupeshappfoster added a commit that referenced this pull request Oct 5, 2023
@bhupeshappfoster
Release/3.3.1 (#480)
d9bae00 
* fixed: an issue where uploaded assets saving to temp directory only

* Feature/512/sync order files on order callback trigger (#476)

* added: file sync logic within order callback action

* added: activity logs for callbacks

* fixed: issue saving file when callback received

* Bug/475/error when plugin tag group is deleted by user (#479)

* added: logic to add plugins tag group if deleted by user

* added: google translator library for google translations (#470)

* updated: change log and version bumped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shnsumit shnsumit shnsumit approved these changes

@sidedwards sidedwards Awaiting requested review from sidedwards

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google translation - 411 Length Required error
3 participants
@bhupeshappfoster @sidedwards @shnsumit