Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Viewer UI Updates #1622

Closed

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Dec 21, 2023

Changes

  • Add in global material settings:
  • Environment sample count for FIS. Changed the default to 4 vs 16 so initial perf is not too slow.
  • Show/Hide Environment toggle.
  • Add in some title coloring on folders and items.
  • Add in some range values so horizontal sliders show up.
  • Add in FXAA pass but disabled this as it doesn't seem to help very much and slows down performance.

Example

  • Snapshot with new UI changes

image

Fix up background color.
Add FXAA pass but disable it for now as it does not seem to help much and slows down rendering a bit.
@jstone-lucasfilm
Copy link
Member

This looks very promising, thanks @kwokcb!

Instead of including all of these ideas in a single pull request, I'd recommend simplifying this down to one idea (e.g. the new sliders for scalar values, which provide a clear improvement over the current behavior).

Some of the other ideas presented here are interesting too, but require more discussion and refinement, e.g. the FXAA toggle, environment sample count, environment checkbox, and initializing folders as closed rather than opened.

@kwokcb
Copy link
Contributor Author

kwokcb commented Dec 22, 2023

I'll pull out the rest later. For now I've pulled out and complete UI attribute support (with some required fixes). in #1623.

@kwokcb kwokcb closed this Jan 4, 2024
@kwokcb
Copy link
Contributor Author

kwokcb commented Jan 4, 2024

#1635 has additional UI changes. #1636 splits out save canvas. FXAA I will not put up a PR since it does not seem to be very good.

@kwokcb kwokcb deleted the webviewer_ui_updates branch May 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants