Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1774 kafka error test fix (SourcePhase capitalization) #1775

Merged
merged 1 commit into from
Apr 26, 2021
Merged

1774 kafka error test fix (SourcePhase capitalization) #1775

merged 1 commit into from
Apr 26, 2021

Conversation

dk1844
Copy link
Contributor

@dk1844 dk1844 commented Apr 26, 2021 •
edited
Loading

For some reason, this test result was previously not correctly checked (only manifested with error log but did not break the test as expected).

Now, this PR fixes the test in terms of string capitalization - while leaving the production code intact.

  • No testing needed - CI build is done automatically and it has been passing.

RN suggestion
KafkaErrorSenderPluginSuite test fix for SourcePhase.{Standardization, Conformance} capitalization.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug D 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 45 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@dk1844 dk1844 changed the base branch from develop to develop-ver-3.0 April 26, 2021 07:55
@dk1844 dk1844 linked an issue Apr 26, 2021 that may be closed by this pull request
KafkaErrorSenderPluginSuite failing on CI #1774
Closed
@dk1844 dk1844 self-assigned this Apr 26, 2021
@dk1844 dk1844 added the PR:no testing needed Only for PR - PR doesn't need to be tested by a tester (person) label Apr 26, 2021
@dk1844 dk1844 merged commit 027f695 into develop-ver-3.0 Apr 26, 2021
@dk1844 dk1844 deleted the 1774-kafkaErrorTestFix branch April 26, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zejnilovic Zejnilovic Zejnilovic approved these changes

@AdrianOlosutean AdrianOlosutean Awaiting requested review from AdrianOlosutean

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@DzMakatun DzMakatun Awaiting requested review from DzMakatun

@HuvarVer HuvarVer Awaiting requested review from HuvarVer

@lokm01 lokm01 Awaiting requested review from lokm01

Assignees

@dk1844 dk1844

Labels
PR:no testing needed Only for PR - PR doesn't need to be tested by a tester (person)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KafkaErrorSenderPluginSuite failing on CI
2 participants
@dk1844 @Zejnilovic