Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaErrorSenderPluginSuite failing on CI #1774

Closed
dk1844 opened this issue Apr 26, 2021 · 1 comment · Fixed by #1775
Closed

KafkaErrorSenderPluginSuite failing on CI #1774

dk1844 opened this issue Apr 26, 2021 · 1 comment · Fixed by #1775
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion

Comments

@dk1844
Copy link
Contributor

dk1844 commented Apr 26, 2021

Describe the bug

KafkaErrorSenderPluginSuite test suite seems be failing on CI, passes on local.

[2021-04-26T06:54:43.905Z] ErrorSenderPluginParams
...
[2021-04-26T06:54:46.778Z] - should fail on incompatible parameters map
[2021-04-26T06:54:48.763Z] 21/04/26 06:54:48 ERROR KafkaErrorSenderPluginImpl: Sending errors to kafka unsuccessful due to: 
[2021-04-26T06:54:48.763Z] org.scalatest.exceptions.TestFailedException: ArrayBuffer("[[sourceSystem1,null,datasetName1,null,1619420083225,18312,output/Path1,enceladusId1,Standardization,stdCastError,E00000,Standardization Error - Type cast,Map(runUrl -> http://runUrls1, datasetVersion -> 1, uniqueRunId -> uniqueRunId, datasetName -> datasetName1, reportVersion -> 1, reportDate -> 2020-03-30, runId -> 1)]]", "[[sourceSystem1,null,datasetName1,null,1619420083225,18312,output/Path1,enceladusId1,Standardization,stdNullError,E00002,Standardization Error - Null detected in non-nullable attribute,Map(runUrl -> http://runUrls1, datasetVersion -> 1, uniqueRunId -> uniqueRunId, datasetName -> datasetName1, reportVersion -> 1, reportDate -> 2020-03-30, runId -> 1)]]") did not contain the same elements as List("[[sourceSystem1,null,datasetName1,null,1619420083225,18312,output/Path1,enceladusId1,standardizaton,stdCastError,E00000,Standardization Error - Type cast,Map(runUrl -> http://runUrls1, datasetVersion -> 1, uniqueRunId -> uniqueRunId, datasetName -> datasetName1, reportVersion -> 1, reportDate -> 2020-03-30, runId -> 1)]]", "[[sourceSystem1,null,datasetName1,null,1619420083225,18312,output/Path1,enceladusId1,standardizaton,stdNullError,E00002,Standardization Error - Null detected in non-nullable attribute,Map(runUrl -> http://runUrls1, datasetVersion -> 1, uniqueRunId -> uniqueRunId, datasetName -> datasetName1, reportVersion -> 1, reportDate -> 2020-03-30, runId -> 1)]]")

Clearly, the test for `SourcePhase.{Standardization, Conformance} is incorrect in terms of capitalization.

To Reproduce

Steps to reproduce the behavior OR commands run:

  1. Run CI on Jenkins and observe the error above.

Expected behavior

The tests should pass in all environments.

@dk1844 dk1844 added bug Something isn't working priority: undecided Undecided priority to be assigned after discussion labels Apr 26, 2021
dk1844 added a commit that referenced this issue Apr 26, 2021
@dk1844 dk1844 linked a pull request Apr 26, 2021 that will close this issue
dk1844 added a commit that referenced this issue Apr 26, 2021
KafkaErrorSenderPluginSuite test fix for SourcePhase.{Standardization, Conformance} capitalization.
@dk1844
Copy link
Contributor Author

dk1844 commented Apr 26, 2021

Closed by #1774

@dk1844 dk1844 closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant