Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci config #194

Merged
merged 11 commits into from
Feb 26, 2025
Merged

Update ci config #194

merged 11 commits into from
Feb 26, 2025

Conversation

anton-seaice
Copy link
Contributor

Closes #193 and #162

@jo-basevi : if you can check syntactical correctness that would be great. also, can we use payu main branch or does it have to be a tagged version ?

@dougiesquire : we could make a special condition to run restart repro on specific test branches if desired ? (e.g. for all branches which contain the word repro ?)

@jo-basevi
Copy link

can we use payu main branch or does it have to be a tagged version ?

The payu module is used as a base when building the test python virtual environments on gadi (smaller environment size compared to building them from scratch). So there's an option for "payu-version": "dev" which will load the payu/dev module.

@anton-seaice
Copy link
Contributor Author

Ok - this might be correct now. My idea is:

run all dev branches using payu/dev module and main branch from model-config-tests

run all release branches using released version

run repro tests more often (which also checks for changes in dependencies too)

Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just have a couple questions/comments. With the top-level defaults being payu/dev module and main branch from model-config-tests, I think "repro" and "scheduled" could have a release-.* section to set fixed versions

        "release-.*": {
            "model-config-tests-version": "0.0.12",
            "payu-version": "1.1.6"
        },

Is "release-1deg_jra55do_ryf" about to be an existing branch? Adding it in the "scheduled" section will trigger a scheduled test for it which it should fail if it can't find the branch.

@anton-seaice
Copy link
Contributor Author

All good thinking @jo-basevi

I think "repro" and "scheduled" could have a release-.* section to set fixed versions

I might have it right now :-)

Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice, the changes look good to me

@anton-seaice anton-seaice merged commit fa624f2 into main Feb 26, 2025
1 check passed
@anton-seaice anton-seaice deleted the 193-update_ci_config branch February 26, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI config
2 participants