-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA checks too onerous #162
Comments
@aidanheerdegen asked: If you think some of the config tests are still useful we could add other markers to enable them to be separated, or split the ones that are definitely for a stable released config into another set entirely. There is already an I think we should only run the qa tests on This would however preclude the (future) option of any qa tests which run on (FYI @CodeGat ) |
ACCESS-NRI/model-config-tests#103 adds a "dev_config" marker we can use now for qa checks on dev branches |
Closed through #194 |
The QA checks for
dev-
configuration branches are too onerous for configurations at an alpha / preliminary development stage.For example:
restart_freq
feature for restart pruning in payu is not implemented yet, so it doesn't make sense to check that restart_freq is date basedmetadata.yaml
For now, we can turn off these checks here and turn them on again when we create
release-
branches. Its also worth following up about having less strenous checks for dev branches compared to release branches.( There github workflow which runs these tests intermittently gives false positives - see ACCESS-NRI/model-config-tests#92. This has by luck meant the current configs exist which failing the requirements of the QA checks).
The text was updated successfully, but these errors were encountered: