Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a util for saving result set #508

Merged
merged 34 commits into from
Oct 25, 2021
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
65da28a
Add a util to save set
zekai427 Oct 13, 2021
82729ec
feat: support option
zekai427 Oct 14, 2021
f380b62
Merge branch 'main' of github.com:4paradigm/OpenMLDB into addSaveResu…
zekai427 Oct 14, 2021
fa47e9c
fix: fix warning
zekai427 Oct 14, 2021
153c815
fix: fix some spelling
zekai427 Oct 14, 2021
a95b209
Merge branch 'main' of github.com:4paradigm/OpenMLDB into addSaveResu…
zekai427 Oct 15, 2021
2a8c8bf
fix: fix bug
zekai427 Oct 15, 2021
f5f093d
fix: fix some code
zekai427 Oct 15, 2021
522191f
fix: fix spelling
zekai427 Oct 18, 2021
af22d10
Merge branch 'main' of github.com:4paradigm/OpenMLDB into addSaveResu…
zekai427 Oct 19, 2021
72fd32d
feat: add SelectIntoOptions
zekai427 Oct 19, 2021
119036d
Merge branch 'main' of github.com:4paradigm/OpenMLDB into addSaveResu…
zekai427 Oct 19, 2021
bf78297
feat: add planNode
zekai427 Oct 19, 2021
4a6f814
fix: fix some code
zekai427 Oct 20, 2021
6f650e5
fix: fix code
zekai427 Oct 20, 2021
53a3ace
Merge branch 'main' of github.com:4paradigm/OpenMLDB into addSaveResu…
zekai427 Oct 20, 2021
8c875dc
fix: fix bug
zekai427 Oct 21, 2021
821f3cd
feat: fix code and add a unit test
zekai427 Oct 21, 2021
e44878c
fix: fix spelling
zekai427 Oct 21, 2021
74c5c4d
fix: fix bug
zekai427 Oct 22, 2021
a876bea
fix: fix sql_cmd.h
zekai427 Oct 22, 2021
5d66d23
feat: add test
zekai427 Oct 22, 2021
ec4ab4c
fix: fix bug
zekai427 Oct 22, 2021
a09dec2
Merge branch 'main' into addSaveResultSet
zekai427 Oct 22, 2021
f199150
fix: fix some code
zekai427 Oct 22, 2021
b715dfe
Merge branch 'addSaveResultSet' of github.com:Kanekanekane/OpenMLDB i…
zekai427 Oct 22, 2021
cfd34fe
fix: fix spelling
zekai427 Oct 22, 2021
9e64018
fix: fix spelling
zekai427 Oct 22, 2021
e3d743d
fix: fix some code
zekai427 Oct 23, 2021
3ea4a22
Merge branch 'main' into addSaveResultSet
zekai427 Oct 23, 2021
bf6fce7
fix: fix a include bug
zekai427 Oct 23, 2021
ea13576
fix: fix bug
zekai427 Oct 25, 2021
7a9ddce
fix: fix spelling
zekai427 Oct 25, 2021
47d54bc
fix: fix spelling
zekai427 Oct 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ ${ZETASQL_LIBS}
${BRPC_LIBS})

if(TESTING_ENABLE)
compile_test(cmd)
compile_test(base)
compile_test(codec)
compile_test(zk)
Expand Down
4 changes: 4 additions & 0 deletions src/base/status.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ struct ResultMsg {
};

enum ReturnCode {
// TODO(zekai): Add some notes, it is hard to use these error codes
kOk = 0,
kTableIsNotExist = 100,
kTableAlreadyExists = 101,
Expand Down Expand Up @@ -167,6 +168,9 @@ enum ReturnCode {
kDatabaseNotFound = 802,
kDatabaseNotEmpty = 803,

// sql_cmd
kSQLCmdRunError = 901,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use more error code for different command error.


kSQLCompileError = 1000,
kSQLRunError = 1001
};
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/openmldb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ int PutData(uint32_t tid, const std::map<uint32_t, std::vector<std::pair<std::st
}
if (ts_dimensions.empty()) {
if (!clients[endpoint]->Put(tid, pid, ts, value, iter->second, format_version)) {
printf("put failed. tid %u pid %u endpoint %s ts %lu \n", tid, pid, endpoint.c_str(), ts);
printf("put failed. tid %u pid %u endpoint %s ts %llu \n", tid, pid, endpoint.c_str(), ts);
return -1;
}
} else {
Expand Down
Loading