feat: add a util for saving result set #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobegit3hub
requested changes
Oct 14, 2021
tobegit3hub
requested changes
Oct 20, 2021
|
Please add an unit test for the added API. It would better to test util functions with mock data. |
tobegit3hub
reviewed
Oct 21, 2021
aceforeverd
reviewed
Oct 22, 2021
tobegit3hub
reviewed
Oct 22, 2021
tobegit3hub
requested changes
Oct 22, 2021
dl239
reviewed
Oct 22, 2021
dl239
reviewed
Oct 22, 2021
tobegit3hub
requested changes
Oct 22, 2021
dl239
approved these changes
Oct 24, 2021
tobegit3hub
approved these changes
Oct 25, 2021
| @@ -167,6 +168,9 @@ enum ReturnCode { | |||
| kDatabaseNotFound = 802, | |||
| kDatabaseNotEmpty = 803, | |||
|
|
|||
| // sql_cmd | |||
| kSQLCmdRunError = 901, | |||
There was a problem hiding this comment.
We may use more error code for different command error.
|
|
||
| file.open(file_path); | ||
| std::string data_append; | ||
| while (!file.eof()) { |
There was a problem hiding this comment.
Use the better API to get the content of file instead of reading line by line.
| getline(file, line); | ||
| data_append.append(line); | ||
| } | ||
| ASSERT_EQ(data_append, "col1,col2key1,1col1,col2key1,1"); |
There was a problem hiding this comment.
The expected data should include the line breakers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECT INTO OUTFILEsyntax #455