-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support parameterized query sdk #248
Merged
imotai
merged 33 commits into
4paradigm:main
from
jingchen2222:feat/support_parameterized_query_sdk
Aug 20, 2021
Merged
feat: support parameterized query sdk #248
imotai
merged 33 commits into
4paradigm:main
from
jingchen2222:feat/support_parameterized_query_sdk
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
============================================
+ Coverage 81.77% 81.82% +0.04%
Complexity 13 13
============================================
Files 283 283
Lines 50417 50458 +41
Branches 29 29
============================================
+ Hits 41230 41285 +55
+ Misses 9178 9164 -14
Partials 9 9
Continue to review full report at Codecov.
|
aceforeverd
reviewed
Aug 16, 2021
…port_parameterized_query_sdk # Conflicts: # .github/workflows/cicd.yaml # src/sdk/sql_sdk_test.h # steps/init_env.sh
…port_parameterized_query_sdk
aceforeverd
reviewed
Aug 19, 2021
aceforeverd
approved these changes
Aug 20, 2021
3 tasks
imotai
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature and bug fix.
What is the current behavior? (You can also link to an open issue here)
SqlRouter support Execute Batch SQL with ParameterRow/Request Row #168
What is the new behavior (if this is a feature change)?
session.Run()
interface. 76542f7Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
ExecuteSQL(db, sql,request)
change toExecuteRequestSQL(db, sql,request)
ExecuteSQL(db, sql, parameter_schema, parameter)
Demo