Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRouter support Execute Batch SQL with ParameterRow/Request Row #168

Closed
jingchen2222 opened this issue Jul 26, 2021 · 0 comments · Fixed by #248
Closed

SqlRouter support Execute Batch SQL with ParameterRow/Request Row #168

jingchen2222 opened this issue Jul 26, 2021 · 0 comments · Fixed by #248
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jingchen2222
Copy link
Collaborator

jingchen2222 commented Jul 26, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

We plan to support execute SQL with given Parameters (RequestRow) under batch-mode .
Describe the solution you'd like
A clear and concise description of what you want to happen.

std::shared_ptr<::hybridse::sdk::ResultSet> SQLClusterRouter::ExecuteSQL(
    const std::string& db, const std::string& sql, std::shared_ptr<openmldb::sdk::SQLRequestRow> parameter,
    ::hybridse::sdk::Status* status) {
    // TODO
}


bool TabletClient::Query(const std::string& db, const std::string& sql,
                         const std::vector<openmldb::type::DataType>& parameter_types,
                         const std::string& parameter_row,
                         brpc::Controller* cntl, ::openmldb::api::QueryResponse* response, const bool is_debug) {
// TODO
}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jingchen2222 jingchen2222 added the enhancement New feature or request label Jul 26, 2021
@jingchen2222 jingchen2222 self-assigned this Jul 26, 2021
@jingchen2222 jingchen2222 added this to the v0.3 milestone Aug 5, 2021
@jingchen2222 jingchen2222 linked a pull request Aug 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant