Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40 fix better error messages #41

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

simonmitchell
Copy link
Contributor

Description

Makes AnyCustomisableRecoverableError conform to LocalizedError so better error messages are provided to users of ThunderRequest

Related Issue

#40

Motivation and Context

Solves bad/non-verbose errors in apps!

How Has This Been Tested?

Has been tested by pointing Blood at this branch of ThunderRequest

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@simonmitchell simonmitchell merged commit 909958e into develop Oct 18, 2019
@simonmitchell simonmitchell deleted the #40-fix_better_error_messages branch April 22, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants