Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyCustomisableRecoverableError doesn't correctly provide localised description #40

Closed
simonmitchell opened this issue Oct 16, 2019 · 0 comments
Labels

Comments

@simonmitchell
Copy link
Contributor

Expected Behaviour

AnyCustomisableRecoverableError (Which we return in most cases to the apps) doesn't implement the LocalizedError protocol, which means when consuming apps call localizedDescription on errors passed by ThunderRequest they are not very verbose!

Current Behaviour

When using error.localizedDescription provided by ThunderRequest errors are not very readable.

Possible Solution

Make AnyCustomisableRecoverableError implement the LocalizedError protocol.

Steps to Reproduce (for bugs)

  1. Turn of networking on device
  2. Perform network request
  3. Log error.localizedDescription
  4. See that it's not very readable!

Your Environment

  • ThunderRequest version: All versions
  • iOS / macOS version: All versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant