This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
💚 ⚡️ Fix circleci test split #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabaktoni
changed the title
FabijanC
suggested changes
Jun 24, 2022
FabijanC
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
None
Development related changes
** 💚 CircleCi Split tasks hotfix**
devnet_in_background made junitxml each object file property represented as util.py but still contained classname based on original filename without extension and with . instead of path /
You can see repercussions in (prev. test metadata):
https://app.circleci.com/pipelines/github/Shard-Labs/starknet-devnet/881/workflows/d90dbd40-4fd9-4503-90db-40674e6d4fe3/jobs/1299/parallel-runs/0/steps/0-106
To satisfy CI same tech. for classname definition is used to feed Ci split algo
Then split can decide based on provided classnames and prev. test metadata how to time-based split that classes.
After the split is done regenerate the given classnames back to filenames and feed them to pytest.
With the new working split algo total test time is now reduced to ⚡️ ~13min
⚡️ parallelism: 2 -> 4
Now that split works we can use parallelism to further increase test speed
with double instances, the test time is reduced by 57.14% which is close to double to ⚡️ ~8min
Checklist: