Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeclareTransaction to types #140

Closed
taco-paco opened this issue Aug 18, 2023 · 1 comment
Closed

DeclareTransaction to types #140

taco-paco opened this issue Aug 18, 2023 · 1 comment
Assignees
@taco-paco

Comments

@taco-paco
Copy link
Contributor

Right now model crate's BroadcastedDeclareTransaction is converted to starknet crate's DeclareTransaction and then on request get_transaction_by_something starknet's DeclareTransaction gets converted to models DeclareTransaction.

TODO: Move model's transaction types to types/rpc. remove starknet's DeclareTransaction and replace with types/rpc DeclareTransaction
@taco-paco taco-paco self-assigned this Aug 18, 2023
@marioiordanov
Copy link
Collaborator

fixed long time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taco-paco taco-paco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taco-paco @marioiordanov