feat: Make sync compatible with node's next
#758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
force-pushed
the
igamigo-next-sync
branch
from
5485737 to
5176cf7
Compare
|
The new |
Comment on lines
37
to
39
| .unwrap() | ||
| .try_into() | ||
| .unwrap(), |
There was a problem hiding this comment.
Can this unwraps be replaced with RpcConversionErrors? Thought I don't know if is worth considering that this will not last long.
Comment on lines
+315
to
+319
| async fn apply_nullifiers( | ||
| &self, | ||
| note_updates: NoteUpdates, | ||
| transactions_to_discard: Vec<TransactionId>, | ||
| ) -> Result<(), StoreError>; |
There was a problem hiding this comment.
We could use a comment here, saying that this is temporary
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| * [BREAKING] Refactored authentication out of the `Client` and added new separate authenticators (#718). | |||
| * Re-exported RemoteTransactionProver in `rust-client` (#752). | |||
| * Moved error handling to the `TransactionRequestBuilder::build()` (#750). | |||
| * [BREAKING] Added starting block number parameter to `CheckNullifiersByPrefix` (#749). | |||
There was a problem hiding this comment.
Maybe mention that nullifiers were removed from SyncState? Also this references a closed PR
SantiagoPittella
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the sync process compatible with
nextuntil the core changes are updated through #650 and #751