Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add block number to CheckNullifiersByPrefix endpoint #749

Closed
wants to merge 2 commits into from
Closed

feat: add block number to CheckNullifiersByPrefix endpoint #749

wants to merge 2 commits into from

Conversation

TomasArrachea
Copy link
Collaborator

@TomasArrachea TomasArrachea commented Feb 19, 2025 •
edited
Loading

This is an auxiliary PR that adds the block number as a parameter for the CheckNullifiersByPrefix endpoint. This was updated in the node in miden-node #707.

@TomasArrachea TomasArrachea changed the title feat: filter nullifiers by blocknum feat: add block_num parameter to check_nullifiers_by_prefix Feb 19, 2025
@TomasArrachea TomasArrachea added no changelog This PR does not require an entry in the `CHANGELOG.md` file and removed no changelog This PR does not require an entry in the `CHANGELOG.md` file labels Feb 19, 2025
@TomasArrachea TomasArrachea marked this pull request as ready for review February 20, 2025 14:41
@TomasArrachea TomasArrachea changed the title feat: add block_num parameter to check_nullifiers_by_prefix feat: add block number to CheckNullifiersByPrefix endpoint Feb 20, 2025
@TomasArrachea TomasArrachea force-pushed the tomasarrachea-filter-nullifiers-by-blocknum branch from eeb123d to 0dbeb4d Compare February 21, 2025 14:19
@TomasArrachea TomasArrachea changed the base branch from tomasarrachea-stream-sync-state to next February 21, 2025 14:19
@TomasArrachea TomasArrachea force-pushed the tomasarrachea-filter-nullifiers-by-blocknum branch from 0dbeb4d to 796df61 Compare February 21, 2025 14:24
@TomasArrachea TomasArrachea marked this pull request as draft February 21, 2025 14:27
@TomasArrachea
Copy link
Collaborator Author

This changes will be merged in #751, that will contain all the changes needed to work with the latest node

@bobbinth
Copy link
Contributor

It may take some time before #751 is merged and it may be good to make sure the latest client is up to date with the latest base/node. @igamigo what do you think?

@igamigo
Copy link
Collaborator

igamigo commented Feb 24, 2025 •
edited
Loading

It may take some time before #751 is merged and it may be good to make sure the latest client is up to date with the latest base/node. @igamigo what do you think?

Yes, we are working on this. Should have a PR up soon.
EDIT: #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomyrd tomyrd tomyrd approved these changes

@SantiagoPittella SantiagoPittella SantiagoPittella approved these changes

@igamigo igamigo Awaiting requested review from igamigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomasArrachea @bobbinth @igamigo @tomyrd @SantiagoPittella