Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lib): prevent TypeError "Cannot read property 'getActiveChildNavs…
…' of undefined" (#323)
- Loading branch information
a0c8496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't fix anything
a0c8496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heidji a new version of the plugin hasn't been released with this fix yet. I've been trying to get them to publish one but they won't. Seems they're not fussed on fixing their stuff.
a0c8496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i copied the rep into my project because i made major changes in it, such as the ability to post notification count to tabs and such. i only copied your change here into my rep and i'm still getting an error.
it makes sense to me because the error says 'nav' is not defined on nav.getActiveChildNavs, so what you did here is make sure that the function returns something. but what if the function isn't called at all? that is the error!