Prevent TypeError "Cannot read property 'getActiveChildNavs' of undefined" #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump - @danielsogl any plans to merge this any-time soon? It's causing issues in our app. |
|
I try to take a look this week! But as far as I can see it should be no problem. |
|
@danielsogl sorry to be a pain, but bumping this for visibility |
This was referenced Aug 14, 2018
|
Would love to see this merged as well! |
|
would also like to see this merged. in the meantime, is there any solution? |
|
I posted a workaround in #308 |
|
@danielsogl thanks for merging, can you release an updated version of the plugin to npm please? |
|
Yeah, please. |
|
cc @ihadeed |
|
Just published |
ihadeed
pushed a commit
that referenced
this pull request
Oct 23, 2018
* chore(package): bump deps and add lint rules * WIP * WIP * WIP * chore: refactor build and readme (#325) * chore(build): add basic travis script (#326) * fix(lib): prevent TypeError "Cannot read property 'getActiveChildNavs' of undefined" (#323) * Remove package-lock.json * 4.3.1 * chore(): update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a potential issue in super-tabs when trying to use multiple super-tabs instances in different pages in the same app. The plugin would break with the TypeError in the title, and a re-start would be needed to fix. This now allows the app to continue as normal.