Update @videojs/http-streaming to the latest version 🚀 #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Closed
gkatsev
added a commit
that referenced
this pull request
Jul 24, 2019
…ndler (#5803)" PR #5083 introduces a fix to #5624, an issue with click events when Polymer's tap gesture is being used. However, this causes an issue where `player.on('click')` no longer triggers from the play toggle. Thus, we revert the change. In addition, looking at Polymer 2 and 3, they recommend against using the tap gesture. Fixes #6092
gkatsev
added a commit
that referenced
this pull request
Jul 24, 2019
…ndler (#5803)" (#6128) PR #5083 introduces a fix to #5624, an issue with click events when Polymer's tap gesture is being used. However, this causes an issue where `player.on('click')` no longer triggers from the play toggle. Thus, we revert the change. In addition, looking at Polymer 2 and 3, they recommend against using the tap gesture. Fixes #6092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.
Version 1.0.0 of @videojs/http-streaming was just published.
The version 1.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of @videojs/http-streaming.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴