Skip to content

Commit

Permalink
revert: "fix(play-toggle): call event.stopPropagation in the click ha…
Browse files Browse the repository at this point in the history
…ndler (#5803)"

PR #5083 introduces a fix to #5624, an issue with click events when
Polymer's tap gesture is being used. However, this causes an issue where
`player.on('click')` no longer triggers from the play toggle. Thus, we
revert the change. In addition, looking at Polymer 2 and 3, they
recommend against using the tap gesture.

Fixes #6092
  • Loading branch information
gkatsev committed Jul 24, 2019
1 parent b9fbd0b commit 5753d06
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/js/control-bar/play-toggle.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class PlayToggle extends Button {
} else {
this.player_.pause();
}
event.stopPropagation();
}

/**
Expand Down

0 comments on commit 5753d06

Please sign in to comment.