fix(integration_test): cucumber-rs improvements #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into cucumber-template
# Conflicts: # Cargo.lock
…into cucumber-template
|
tari#4879 merged |
sdbondi
added a commit
to jorgeantonio21/tari-dan
that referenced
this pull request
Nov 10, 2022
* development: fix(integration_test): cucumber-rs improvements (tari-project#177) feat: add sorting to recent TX in webgui (tari-project#192) feat: add templates to web gui (tari-project#190)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Nov 10, 2022
* development: fix(integration_test): cucumber-rs improvements (tari-project#177) feat: add sorting to recent TX in webgui (tari-project#192) feat: add templates to web gui (tari-project#190) fix: remove generic from bucket (tari-project#185) fix: add committee size constant, to remove duplicate code (see tari-project#174) (tari-project#187) fix: compile_template outputs compile failure to stderr (tari-project#186) feat: state sync on epoch change (see tari-project#154) (tari-project#166) fix: check pledges against changes being made (tari-project#181) feat: return QC to client for submit-transaction calls (tari-project#172) fix: vote reject when wasm panics (tari-project#171)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Nov 10, 2022
* development: fix(integration_test): cucumber-rs improvements (tari-project#177) feat: add sorting to recent TX in webgui (tari-project#192) feat: add templates to web gui (tari-project#190) fix: remove generic from bucket (tari-project#185) fix: add committee size constant, to remove duplicate code (see tari-project#174) (tari-project#187) fix: compile_template outputs compile failure to stderr (tari-project#186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Previously, the cucumber integration test didn't allow VN registration, due to an invalid consensus constant in the
localnetnetwork.Also, manual inspection (gRPC, json-rpc, database files, etc.) should be easier to do, so new cucumber steps are added to enable it.
Depends on tari#4879
How Has This Been Tested?
The integration tests now allows registration of VNs and asserts that they are indeed registered. The template function call does still fail, so it's commented out.