fix: vote reject when wasm panics #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
commented
Nov 1, 2022
| @@ -2,7 +2,8 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | |||
| <link rel="icon" href="data:;base64,="> | |||
There was a problem hiding this comment.
Removes the log in the console
stringhandler
commented
Nov 1, 2022
| @@ -117,7 +116,7 @@ impl BaseNodeClient for GrpcBaseNodeClient { | |||
| }); | |||
| }, | |||
| Ok(None) => { | |||
| info!(target: LOG_TARGET, "No new validator nodes for this epoch"); | |||
| trace!(target: LOG_TARGET, "No new validator nodes for this epoch"); | |||
There was a problem hiding this comment.
removes an extra log in the console
sdbondi
approved these changes
Nov 2, 2022
|
utACK |
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Nov 10, 2022
* development: fix(integration_test): cucumber-rs improvements (tari-project#177) feat: add sorting to recent TX in webgui (tari-project#192) feat: add templates to web gui (tari-project#190) fix: remove generic from bucket (tari-project#185) fix: add committee size constant, to remove duplicate code (see tari-project#174) (tari-project#187) fix: compile_template outputs compile failure to stderr (tari-project#186) feat: state sync on epoch change (see tari-project#154) (tari-project#166) fix: check pledges against changes being made (tari-project#181) feat: return QC to client for submit-transaction calls (tari-project#172) fix: vote reject when wasm panics (tari-project#171)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the WASM panics or execution fails, vote as reject instead of exiting
Motivation and Context
Some old WASMs no longer work after recent commits. Invoking them causes the hotstuff waiter to exit instead of voting as a reject
How Has This Been Tested?
Manually