Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix CI and translation tests #2135

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Conversation

kcaran
Copy link

@kcaran kcaran commented Mar 13, 2025

Updated the Github CI to use Ubuntu 24.04 correctly. The translation tests needed the $LANG environmental variable set and and the date regular expressions needed the /u UTF-8 flag. I also included PHP 8.3 and 8.4 and remove 7.4 and 8.0.

@kcaran
Copy link
Author

kcaran commented Mar 13, 2025

I wrote up how I debugged the Github Actions: https://www.kcaran.com/posts/debugging-github-ci-actions.html

@nodiscc nodiscc self-requested a review March 13, 2025 21:32
@nodiscc nodiscc added bug it's broken! tools developer tools labels Mar 13, 2025
@nodiscc nodiscc added this to the 0.14.1 milestone Mar 13, 2025
Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a w e s o m e
Thank you, and great writeup on the debugging process

I don't know this env variable was named UT_LOCALE in the first place, I can't find any reference to this name anywhere. In hindsight LANG is obviously correct.

The change to non-breaking spaces was tricky, @thican also had identified it in #2120, so thank you both.

The tests breaking all of a sudden means we have a dependency that is not properly pinned somewhere (I suspect the stray composer update in the test suite has something to do with it), will deal with this in a separate PR.

You just need to re-enable all php versions in the test matrix ^ comment above

@nodiscc nodiscc changed the title Updated Github CI to Ubuntu 24.04 tests: fix CI and translation tests Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! in review tools developer tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants