Fixed failing tests in Github CI for Ubuntu 22.04 #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was an intermediate step. We're on the latest version of Ubuntu now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swore that as an American I wasn't going to get involved in the failing translation tests, but it seemed worth the effort to get the tests passing. I learned a lot about docker and debugging the Github CI.
In the end, the fix is to use Ubuntu 22.04. I am close to get it working for 24.04 (ubuntu-latest), but I think this is a good intermediate step. In addition to bumping the ubuntu version, we should probably include PHP 8.3 and PHP 8.4. Do you think we should remove 7.4 and 8.0 as those are end of life?
I've added
.github/act/Dockerfilewhich will help debug these sorts of issues in the future.