Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_action_client failures #471

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix test_action_client failures #471

merged 1 commit into from
Dec 5, 2019
+5 −0

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Dec 5, 2019 •
edited
Loading

ros2/rcl#541 triggered some failures in CI, though the problem was that the test wasn't creating an status publisher.

@ivanpauno
Fix test_action_client.py failures
025c365 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Dec 5, 2019
@ivanpauno ivanpauno requested a review from jacobperron December 5, 2019 13:16
@ivanpauno ivanpauno self-assigned this Dec 5, 2019
@ivanpauno ivanpauno mentioned this pull request Dec 5, 2019
Closed
@ivanpauno
Copy link
Member Author

ivanpauno commented Dec 5, 2019 •
edited
Loading

  • Linux Build Status
  • Arch Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno mentioned this pull request Dec 5, 2019
Merged
@ivanpauno ivanpauno requested a review from hidmic December 5, 2019 15:49
hidmic
hidmic approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains... LGTM!

@ivanpauno ivanpauno merged commit 9a4471c into master Dec 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-test-action-client branch December 5, 2019 17:18
@jacobperron
Copy link
Member

Glad you found the real issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @jacobperron @hidmic