Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable/disable rosout logging in each node individually #469

Merged
merged 3 commits into from
Dec 5, 2019
Merged

enable/disable rosout logging in each node individually #469

merged 3 commits into from
Dec 5, 2019

Conversation

Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Dec 2, 2019 •
edited
Loading

This is following PR for ros2/rcl#532.
Provide option to enable/disable rosout logging for rclpy.
Related issue is ros2/rcl#510.

There are 2 commits. One is for implementation. The other is for test codes.

There is a problem on test. Test codes needs python3-parameterized package.
'python3-parameterized' package is not supported currently in python test of ros2.
Whether do we can use 'python3-parameterized' this time?
If yes, do I need to update other repositories? (such as rosdistro, ros2 CI or some document) Not very clear about these steps.

@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Dec 2, 2019
Merged
@Barry-Xu-2018
Copy link
Contributor Author

@ivanpauno

Please review this PR.

@Barry-Xu-2018 Barry-Xu-2018 changed the title Node enable rosout enable/disable rosout logging in each node individually Dec 2, 2019
ivanpauno
ivanpauno reviewed Dec 2, 2019
View reviewed changes
@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Dec 3, 2019
Closed
@Barry-Xu-2018
Copy link
Contributor Author

@ivanpauno

I have updated test codes based on pytest.
Please review again.

@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 @ivanpauno

LGTM

@ivanpauno
Copy link
Member

ivanpauno commented Dec 4, 2019 •
edited
Loading

  • Linux Build Status
  • AArch64 Build Status
  • macOS Build Status
  • Windows Build Status

Failures are all unrelated, and being fixed by #471.

@ivanpauno
Copy link
Member

Going in! Thanks for the contribution @Barry-Xu-2018 !

@ivanpauno ivanpauno merged commit 23827e5 into ros2:master Dec 5, 2019
wjwwood
wjwwood reviewed Apr 24, 2020
View reviewed changes
rclpy/test/test_logging_rosout.py
)

node.get_logger().info('SOMETHING')
executor.spin_once(timeout_sec=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanpauno (tagging you because you reviewed it), watch out for things like this. It's really fragile, we're seeing this test fail a lot either due to the timeout before the event or because spinning once does not guarantee that the event you wanted handled was the one that would be handled...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: https://ci.ros2.org/job/ci_osx/8540/testReport/rclpy.src.ros2.rclpy.rclpy.test/test_logging_rosout/test_enable_rosout_enable_global_rosout_enable_node_rosout_True_True_True_/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwwood

our bad, sorry about that.
we will submit issue against problem and try to fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wjwwood.
I overlooked that when reviewing, but the test is definitely flaky.

I've created an issue #546.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fujitatomoya if you're not planning to work on a fix in a near future, let me know and I will work on it. Thanks!

Copy link
Collaborator

@fujitatomoya fujitatomoya Apr 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanpauno

i think i can work on this early next week, but if you already have idea, you can go ahead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwwood

Thank you for pointing out my mistake. I will fix it.

@ivanpauno @fujitatomoya

It's my fault. I will fix this problem tomorrow in #546.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I wasn't trying to call anyone out, just wanted to point it out before I forgot and explain why it is fragile.

@ivanpauno ivanpauno mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood left review comments

@dirk-thomas dirk-thomas dirk-thomas left review comments

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Barry-Xu-2018 @fujitatomoya @ivanpauno @wjwwood @dirk-thomas