-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cherry pick for 1.4 #2051
chore: Cherry pick for 1.4 #2051
Conversation
Signed-off-by: Juncheng Zhu <[email protected]>
…2033) Signed-off-by: Akash Singhal <[email protected]>
Signed-off-by: Binbin Li <[email protected]>
….3.0 (ratify-project#2045) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Binbin Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks binbin
@binbin-li , whats the best way to run the aks test on the latest changes for the release branch? |
since it's a PR from fork, we cannot run the aks test. I'll run it in my forked repo and post result here. Another workaround is to create a cherry-pick branch under ratify repo and merge from it but it's not applied to all contributors except maintainers. |
Description
What this PR does / why we need it:
Cherry-pick from dev to release-1.4
We may need to create a merge commit instead of squash commit to keep the commit history.
Ran aks test in my forked repo:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change